Skip to content

Fix sntp_get_real_time prototype in header #7707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2020
Merged

Fix sntp_get_real_time prototype in header #7707

merged 3 commits into from
Nov 14, 2020

Conversation

earlephilhower
Copy link
Collaborator

sntp_get_real_time takes a time_t in the core, but in the header it
was listed as long. Make them both match by changing the header.

@earlephilhower
Fix sntp_get_real_time prototype in header
4ec7e16 
sntp_get_real_time takes a `time_t` in the core, but in the header it
was listed as `long`.  Make them both match by changing the header.
@earlephilhower earlephilhower requested a review from d-a-v November 14, 2020 02:02
@earlephilhower
Copy link
Collaborator Author

This was spotted while doing the newlib 3.3 port where time_t has gone to 64-bit (i.e. a long long) to avoid the year 2038 problem. On the current core, this is just a cleanup and shouldn't change any code.

@d-a-v d-a-v merged commit 417aacc into esp8266:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v Awaiting requested review from d-a-v

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@earlephilhower @d-a-v